Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: failing on Go 1.10 #28040

Closed
bradfitz opened this issue Oct 5, 2018 · 3 comments
Closed

x/tools/go/packages: failing on Go 1.10 #28040

bradfitz opened this issue Oct 5, 2018 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.12

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Oct 5, 2018

x/tools is broken on Go 1.10
https://build.golang.org/log/3b7dfcf2bc34eab6b8d3f552f77bb57f9b5b18cf

--- FAIL: TestLoadAbsolutePath (0.37s)
	packages_test.go:354: initial packages loaded: got [[b a]], want [a b]
FAIL
FAIL	golang.org/x/tools/go/packages	25.074s

and on another builder:

https://build.golang.org/log/d99665968216655f6a954e41f1c8a05e6672a57d

--- FAIL: TestLoadImportsC (0.99s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x63c04a]

goroutine 71 [running]:
testing.tRunner.func1(0xc4203c4000)
	/workdir/go/src/testing/testing.go:742 +0x29d
panic(0x69a140, 0x854950)
	/workdir/go/src/runtime/panic.go:502 +0x229
golang.org/x/tools/go/packages.createTestVariants.func1(0x0, 0xc42011f490)
	/workdir/gopath/src/golang.org/x/tools/go/packages/golist_fallback.go:266 +0x6a
golang.org/x/tools/go/packages.createTestVariants.func1(0xc420392000, 0xc42011f490)
	/workdir/gopath/src/golang.org/x/tools/go/packages/golist_fallback.go:270 +0x179
golang.org/x/tools/go/packages.createTestVariants(0xc4203ba1e0, 0xc4203aac40, 0xc42041a380)
	/workdir/gopath/src/golang.org/x/tools/go/packages/golist_fallback.go:299 +0x389
golang.org/x/tools/go/packages.golistDriverFallback(0xc42025f788, 0xc4202f6c20, 0x2, 0x2, 0x0, 0x721360, 0xc42004d030)
	/workdir/gopath/src/golang.org/x/tools/go/packages/golist_fallback.go:246 +0x765
golang.org/x/tools/go/packages.goListDriver.func1(0xc42025f788, 0xc4203b0420, 0x2, 0x2, 0x1, 0x0, 0x0)
	/workdir/gopath/src/golang.org/x/tools/go/packages/golist.go:48 +0xc1
golang.org/x/tools/go/packages.goListDriver(0xc42025f788, 0xc4203b0400, 0x2, 0x2, 0xc42025f780, 0xc42025f7b0, 0xc4203b0400)
	/workdir/gopath/src/golang.org/x/tools/go/packages/golist.go:59 +0xd4e
golang.org/x/tools/go/packages.defaultDriver(0xc42025f788, 0xc4203b0400, 0x2, 0x2, 0xf, 0x83fea6, 0x22)
	/workdir/gopath/src/golang.org/x/tools/go/packages/packages.go:171 +0x68
golang.org/x/tools/go/packages.Load(0xc42002b728, 0xc4203b0400, 0x2, 0x2, 0x445387, 0xc42038f4e8, 0xc420395da0, 0x2, 0x2)
	/workdir/gopath/src/golang.org/x/tools/go/packages/packages.go:157 +0x6f
golang.org/x/tools/go/packages_test.TestLoadImportsC(0xc4203c4000)
	/workdir/gopath/src/golang.org/x/tools/go/packages/packages_test.go:304 +0xdd
testing.tRunner(0xc4203c4000, 0x6fa7b8)
	/workdir/go/src/testing/testing.go:777 +0xd0
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:824 +0x2e0
FAIL	golang.org/x/tools/go/packages	3.222s
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Oct 5, 2018
@bradfitz bradfitz added this to the Go1.12 milestone Oct 5, 2018
@alandonovan alandonovan assigned matloob and unassigned alandonovan Oct 5, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/140121 mentions this issue: go/packages: skip TestLoadImportsC when Go has been built without cgo

gopherbot pushed a commit to golang/tools that referenced this issue Oct 5, 2018
@matloob
go/packages: skip TestLoadImportsC when Go has been built without cgo
e60d0f5 
This test is unsurprisingly failing on the nocgo builder because
the cgo packages don't exist on those builders.

Updates golang/go#28040

Change-Id: I633b73bb48e76824645e4e8dd141fb42c9adc19f
Reviewed-on: https://go-review.googlesource.com/c/140121
Reviewed-by: Brad Fitzpatrick <[email protected]>
@bradfitz
Copy link
Contributor Author

Ping somebody. Please fix or skip these tests.

Red on the dashboard is distracting.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/148880 mentions this issue: go/packages: fix flaky TestJSON and reenable it on Go 1.10

@klauspost klauspost mentioned this issue Jan 2, 2019
Closed
@golang golang locked and limited conversation to collaborators Nov 12, 2019
@rsc rsc unassigned matloob Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@bradfitz @alandonovan @gopherbot @matloob