Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: build fails when setting linker to lld using ldflags [1.11 backport] #27293

Closed
gopherbot opened this issue Aug 28, 2018 · 2 comments
Closed

cmd/go: build fails when setting linker to lld using ldflags [1.11 backport] #27293

gopherbot opened this issue Aug 28, 2018 · 2 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.11.1

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #27110 to be considered for backport to the next 1.11 minor release.

@gopherbot please backport to 1.11
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 28, 2018
@gopherbot gopherbot mentioned this issue Aug 28, 2018
Closed
@gopherbot gopherbot added this to the Go1.11.1 milestone Aug 28, 2018
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/134057 mentions this issue: cmd/link: don't pass all linker args when testing flag

gopherbot pushed a commit that referenced this issue Sep 11, 2018
@ianlancetaylor
cmd/link: don't pass all linker args when testing flag
023dbb1 
Some linker flags can actually be input files, which can cause
misleading errors when doing the trial link, which can cause the
linker to incorrectly decide that the flag is not supported, which can
cause the link to fail.

Fixes #27510
Updates #27110
Updates #27293

Change-Id: I70c1e913cee3c813e7b267bf779bcff26d4d194a
Reviewed-on: https://go-review.googlesource.com/134057
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Lynn Boger <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
@ianlancetaylor
Copy link
Member

This is an uncommon case and the change that fixed #27110 introduced a bug. Let's not backport the change.

@golang golang locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.11.1
Development

No branches or pull requests
2 participants
@ianlancetaylor @gopherbot