Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: enable windows/arm before Go 1.14 release #27103

Closed
bradfitz opened this issue Aug 20, 2018 · 3 comments
Closed

cmd/vet: enable windows/arm before Go 1.14 release #27103

bradfitz opened this issue Aug 20, 2018 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Milestone
Backlog

Comments

@bradfitz
Copy link
Contributor

Reminder bug to re-enable windows/arm in cmd/vet/all before releasing Go 1.12.

(windows/arm is #26148)

/cc @jordanrh1
@bradfitz bradfitz added OS-Windows NeedsFix The path to resolution is known, but the work has not been done. labels Aug 20, 2018
@bradfitz bradfitz added this to the Go1.12 milestone Aug 20, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/130055 mentions this issue: cmd/vet: exclude windows/arm from cmd/vet

gopherbot pushed a commit that referenced this issue Aug 20, 2018
@jordanrh1 @bradfitz
cmd/vet: exclude windows/arm from cmd/vet
c589b9e 
Updates #27103

Change-Id: I1f7d198879e5912661e4156a86e13de2698a5473
Reviewed-on: https://go-review.googlesource.com/130055
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019
@agnivade agnivade changed the title cmd/vet: enable windows/arm before Go 1.12 release cmd/vet: enable windows/arm before Go 1.13 release Feb 28, 2019
@bradfitz
Copy link
Contributor Author

@jordanrh1, what's the status of the windows/arm port and this bug?

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@agnivade agnivade changed the title cmd/vet: enable windows/arm before Go 1.13 release cmd/vet: enable windows/arm before Go 1.14 release Aug 11, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@ALTree
Copy link
Member

ALTree commented Jul 22, 2020 •
edited
Loading

This issue was opened as a reminder to remove some temporary code from cmd/vet/all/main.go, but that file no longer exists (vet is now run as part of go test); moreover the windows/arm port is currently inactive, so I think it's safe to close this issue.

@ALTree ALTree closed this as completed Jul 22, 2020
@golang golang locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@bradfitz @rsc @andybons @ALTree @gopherbot