Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vendor/.../pprof/internal/binutils: TestMachoFiles fails #24508

Closed
hyangah opened this issue Mar 23, 2018 · 7 comments
Closed

cmd/vendor/.../pprof/internal/binutils: TestMachoFiles fails #24508

hyangah opened this issue Mar 23, 2018 · 7 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unplanned

Comments

@hyangah
Copy link
Contributor

hyangah commented Mar 23, 2018

https://build.golang.org/log/1cbedd8b8b11d1baadcbfabcf8d8809ece5ab307

New failures caused by cl/101736
Trybot run didn't detect this early.
@ALTree
Copy link
Member

ALTree commented Mar 23, 2018 •
edited
Loading

Sigh. I suggest reverting, opening an issue upstream, and then we can re-vendor again when it's fixed. IIRC the darwin trybots are down, we can't afford having all the 3 darwin builders down too.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/102316 mentions this issue: Revert "cmd/vendor/.../pprof: refresh from upstream@a74ae6f"

gopherbot pushed a commit that referenced this issue Mar 23, 2018
@hyangah
Revert "cmd/vendor/.../pprof: refresh from upstream@a74ae6f"
5873403 
This reverts commit c6e69ec.

Reason for revert: Broke builders. #24508

Change-Id: I66abff0dd14ec6e1f8d8d982ccfb0438633b639d
Reviewed-on: https://go-review.googlesource.com/102316
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
@hyangah
Copy link
Contributor Author

hyangah commented Mar 23, 2018

Strange. I can't reproduce the test failure on my mac.

@mvdan
Copy link
Member

mvdan commented Mar 23, 2018

Filed upstream: google/pprof#342

@andybons andybons added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Mar 23, 2018
@andybons andybons added this to the Unplanned milestone Mar 23, 2018
@mvdan mvdan mentioned this issue Apr 3, 2018
Closed
@hyangah
Copy link
Contributor Author

hyangah commented Apr 4, 2018

The upstream test code was fixed. @mvdan are you going to update the vendored pprof?

@mvdan mvdan self-assigned this Apr 4, 2018
@mvdan
Copy link
Member

mvdan commented Apr 4, 2018

Yes; I meant to send this today but got sidetracked.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/105275 mentions this issue: cmd/vendor/.../pprof: update to 0f7d9ba1

@golang golang locked and limited conversation to collaborators Apr 6, 2019
@rsc rsc unassigned mvdan Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
5 participants
@andybons @mvdan @ALTree @hyangah @gopherbot