-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/trace: TestAnalyzeAnnotationGC flaky #24081
Comments
Change https://golang.org/cl/96855 mentions this issue: |
This is for debugging the reported flaky tests. Update #24081 Change-Id: Ica046928f675d69e38251a47a6f225efedce920c Reviewed-on: https://go-review.googlesource.com/96855 Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]>
Change https://golang.org/cl/97555 mentions this issue: |
I sent a cl to fix an obvious bug. But the CL doesn't eliminate the flakiness completely. I guess it surfaced issues with timestamps or trace logging on Windows. I captured a trace from a failed test run on gomote buildlet, where the user code reports 977us for debug.FreeOSMemory call, but the corresponding GCDone-GCStart timestamps report 1.383112ms (also the UI too) $ go tool trace -d TestAnalyzeAnnotationGC.trace.failed | egrep "GCStart|GCDone" 2018/02/27 18:45:35 Parsing trace... 68810 GCStart p=1000004 g=0 off=403 seq=0 1451922 GCDone p=1 g=0 off=449 |
Update #24081 Change-Id: Ieccfb03c51e86f35d4629a42959c80570bd93c33 Reviewed-on: https://go-review.googlesource.com/97555 Reviewed-by: Brad Fitzpatrick <[email protected]> Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
@hyangah I did not look into this problem. But just a general comment - you cannot sleep for less than 1ms on Windows. Alex |
Thanks @alexbrainman I don't know why we saw this in only windows buildlets so far. Given #16755, I think this can happen in unix systems. I will skip this test in -short mode for now. Will take a look at the Solaris case separately. |
Solaris: Indeed duplicate of #16755 https://build.golang.org/log/844551cc3c0f145093b6a58286e7a9f81edccec0 --- FAIL: TestAnalyzeAnnotations (0.00s) |
Change https://golang.org/cl/97757 mentions this issue: |
TestAnalyzeAnnotationGC has been flaky on Windows and Solaris since it was introduced.
On Windows it fails with:
On Solaris it fails with:
$ greplogs -dashboard -E TestAnalyzeAnnotationGC -l -md
2018-02-21T19:48:35-cacf812/windows-386-2008
2018-02-21T19:48:35-cacf812/windows-amd64-2016
2018-02-21T20:14:30-3e1ac1b/windows-amd64-2008
2018-02-21T20:32:35-ed1959c/windows-amd64-2016
2018-02-21T21:04:09-e02d6bb/windows-amd64-2012
2018-02-22T04:10:07-f4c3072/solaris-amd64-smartosbuildlet
2018-02-22T15:17:52-ef3ab3f/solaris-amd64-smartosbuildlet
2018-02-22T16:28:38-2465ae6/windows-386-2008
2018-02-23T13:49:55-9ee78af/windows-386-2008
2018-02-23T16:48:01-fceaa2e/solaris-amd64-smartosbuildlet
2018-02-23T16:48:01-fceaa2e/windows-386-2008
/cc @hyangah
The text was updated successfully, but these errors were encountered: