runtime: if we make a 1.6.3 release, backport the macOS Sierra patch #16354
Labels
Milestone
Comments
|
CL https://golang.org/cl/24967 mentions this issue. |
gopherbot
pushed a commit
that referenced
this issue
Jul 18, 2016
In the beta version of the macOS Sierra (10.12) release, the gettimeofday system call changed on x86. Previously it always returned the time in the AX/DX registers. Now, if AX is returned as 0, it means that the system call has stored the values into the memory pointed to by the first argument, just as the libc gettimeofday function does. The libc function handles both cases, and we need to do so as well. Fixes #16272. Fixes #16354. Change-Id: Ibe5ad50a2c5b125e92b5a4e787db4b5179f6b723 Reviewed-on: https://go-review.googlesource.com/24812 Reviewed-by: Brad Fitzpatrick <[email protected]> Reviewed-on: https://go-review.googlesource.com/24967
gopherbot
pushed a commit
that referenced
this issue
Jul 18, 2016
Updates #16354 Updates #16272 Change-Id: I73e8df40621a0a17a1990f3b10ea996f4fa738aa Reviewed-on: https://go-review.googlesource.com/25014 Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
|
Not fixed. #16570 (comment) |
|
It was fixed. But Beta 4 broke it again. We'll open a new bug rather than repurpose this one, though. |
|
did a bug to track backporting the ultimate sierra fix to 1.6.x ever get opened? |
|
not seeing it in https://github.com/golang/go/milestone/45, opened #17234 to track |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If we make a 1.6.3 release, it should include the fix for issue #16272 , so that 1.6.3 will work correctly on Sierra.
The text was updated successfully, but these errors were encountered: