Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: run all tests on some builder #12508

Closed
josharian opened this issue Sep 5, 2015 · 8 comments
Closed

build: run all tests on some builder #12508

josharian opened this issue Sep 5, 2015 · 8 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unplanned

Comments

@josharian
Copy link
Contributor

The builders run the -short tests. However, we've seen non-short tests fail in the past. It'd be good for at least one builder somewhere on at least one arch/os to run the full suite.

cc @bradfitz
@Thomasdezeeuw
Copy link
Contributor

Another possibility might be to run the "long" go test once a day/week on all the current builders. This way no extra builders are required. The downside is that when the tests fails multiple commits could be blamed and require a little extra debugging.

@bradfitz
Copy link
Contributor

bradfitz commented Sep 5, 2015

The majority of our builders are virtual, and very cheap. We can run more configs (like a full one) if they're useful.

@rsc
Copy link
Contributor

rsc commented Oct 23, 2015

Another option is to make some longer tests (normally disabled by -short) run anyway if they notice they are on a (any) builder. That might be better than yet another special config that we have to remember what it means.

@rsc rsc added this to the Unplanned milestone Oct 23, 2015
@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Oct 30, 2015
@bradfitz
Copy link
Contributor

Also, now that we shard tests, it might not even be much longer to run full tests on some of the more widely-sharded builders.

This was referenced Mar 22, 2018
Closed
Closed
@josharian
Copy link
Contributor Author

cc @andybons

Unnoticed non-short test failures get noticed every few months. The latest is #24464.

@andybons andybons self-assigned this Mar 23, 2018
@josharian josharian mentioned this issue Mar 30, 2018
Closed
@ysmolski
Copy link
Member

And more cases: #25367 #24436

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/113435 mentions this issue: cmd/dist: add support for disabling short mode

gopherbot pushed a commit that referenced this issue May 16, 2018
@bradfitz
cmd/dist: add support for disabling test -short mode
594a6bd 
So we can have builders running go test -short=false.

Updates #12508

Change-Id: If90f0f6d9f89268c33b1d1876139ad551fecd3d8
Reviewed-on: https://go-review.googlesource.com/113435
Reviewed-by: Josh Bleecher Snyder <[email protected]>
Reviewed-by: Bryan C. Mills <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/113436 mentions this issue: dashboard: add "longtest" builder to run all tests, without -short mode

@golang golang locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
7 participants
@bradfitz @josharian @rsc @ysmolski @andybons @Thomasdezeeuw @gopherbot