Skip to content

Commit

Permalink
[release-branch.go1.18] encoding/xml: skip TestCVE202230633 for short…
Browse files Browse the repository at this point in the history
… tests

TestCVE202230633 uses a bunch of memory, and the input cannot be
feasibly reduced while maintaining the behavior hasn't regressed. This
test could be reasonably removed, but I'd rather keep it around if we
can.

Updates #53814.
Fixes #54128.

Change-Id: Ie8b3f306efd20b2d9c0fb73122c26351a55694c4
Reviewed-on: https://go-review.googlesource.com/c/go/+/417655
Run-TryBot: Roland Shoemaker <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
(cherry picked from commit 783ff7d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/421094
Reviewed-by: Cherry Mui <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
  • Loading branch information
rolandshoemaker authored and dmitshur committed Aug 3, 2022
1 parent be59153 commit fcdd099
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/encoding/xml/read_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"errors"
"io"
"reflect"
"runtime"
"strings"
"testing"
"time"
Expand Down Expand Up @@ -1084,8 +1083,8 @@ func TestUnmarshalWhitespaceAttrs(t *testing.T) {
}

func TestCVE202230633(t *testing.T) {
if runtime.GOARCH == "wasm" {
t.Skip("causes memory exhaustion on js/wasm")
if testing.Short() {
t.Skip("test requires significant memory")
}
defer func() {
p := recover()
Expand Down

0 comments on commit fcdd099

Please sign in to comment.