Skip to content

Commit

Permalink
cmd/go: port TestIssue16471 to a script test and add verbose logging
Browse files Browse the repository at this point in the history
For #50471

Change-Id: I082c1f96113a3228f2ef423a04eaa9fbaa6c7522
Reviewed-on: https://go-review.googlesource.com/c/go/+/376359
Reviewed-by: Robert Findley <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
  • Loading branch information
Bryan C. Mills authored and gopherbot committed Jul 12, 2022
1 parent 9c2526e commit c2edb2c
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 15 deletions.
15 changes: 0 additions & 15 deletions src/cmd/go/go_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -991,21 +991,6 @@ func TestIssue10952(t *testing.T) {
tg.run("get", "-d", "-u", importPath)
}

func TestIssue16471(t *testing.T) {
testenv.MustHaveExternalNetwork(t)
testenv.MustHaveExecPath(t, "git")

tg := testgo(t)
defer tg.cleanup()
tg.parallel()
tg.tempDir("src")
tg.setenv("GOPATH", tg.path("."))
tg.must(os.MkdirAll(tg.path("src/rsc.io/go-get-issue-10952"), 0755))
tg.runGit(tg.path("src/rsc.io"), "clone", "https://github.com/zombiezen/go-get-issue-10952")
tg.runFail("get", "-u", "rsc.io/go-get-issue-10952")
tg.grepStderr("rsc.io/go-get-issue-10952 is a custom import path for https://github.com/rsc/go-get-issue-10952, but .* is checked out from https://github.com/zombiezen/go-get-issue-10952", "did not detect updated import path")
}

// Test git clone URL that uses SCP-like syntax and custom import path checking.
func TestIssue11457(t *testing.T) {
testenv.MustHaveExternalNetwork(t)
Expand Down
22 changes: 22 additions & 0 deletions src/cmd/go/testdata/script/get_issue16471.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
[!net] skip
[!exec:git] skip

env GO111MODULE=off

cd rsc.io/go-get-issue-10952

exec git init
exec git add foo.go
exec git config user.name Gopher
exec git config user.email [email protected]
exec git commit -a -m 'initial commit'
exec git remote add origin https://github.com/golang/go-get-issue-10952

exec git status

! go get -x -u rsc.io/go-get-issue-10952
stderr '^package rsc.io/go-get-issue-10952: rsc\.io/go-get-issue-10952 is a custom import path for https://github.com/rsc/go-get-issue-10952, but .* is checked out from https://github.com/golang/go-get-issue-10952$'

-- rsc.io/go-get-issue-10952/foo.go --
// Junk package to test go get.
package foo

0 comments on commit c2edb2c

Please sign in to comment.