Skip to content

Commit

Permalink
cmd/go: convert TestPackageNotStaleWithTrailingSlash to script framework
Browse files Browse the repository at this point in the history
Part of converting all tests to script framework to improve
test parallelism.

Updates #36320
Updates #17751

Change-Id: I1020feaa4ddb40ff52c46728bc4973cea4c7b066
Reviewed-on: https://go-review.googlesource.com/c/go/+/214391
Reviewed-by: Jay Conrod <[email protected]>
  • Loading branch information
matloob committed Feb 27, 2020
1 parent 2c859ea commit bec91ce
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 19 deletions.
19 changes: 0 additions & 19 deletions src/cmd/go/go_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1151,25 +1151,6 @@ func TestPackageMainTestCompilerFlags(t *testing.T) {
tg.grepStderr(`([\\/]compile|gccgo).* (-p p1|-fgo-pkgpath=p1).*p1\.go`, "should have run compile -p p1 p1.go")
}

// Issue 12690
func TestPackageNotStaleWithTrailingSlash(t *testing.T) {
skipIfGccgo(t, "gccgo does not have GOROOT")
tg := testgo(t)
defer tg.cleanup()

// Make sure the packages below are not stale.
tg.wantNotStale("runtime", "", "must be non-stale before test runs")
tg.wantNotStale("os", "", "must be non-stale before test runs")
tg.wantNotStale("io", "", "must be non-stale before test runs")

goroot := runtime.GOROOT()
tg.setenv("GOROOT", goroot+"/")

tg.wantNotStale("runtime", "", "with trailing slash in GOROOT, runtime listed as stale")
tg.wantNotStale("os", "", "with trailing slash in GOROOT, os listed as stale")
tg.wantNotStale("io", "", "with trailing slash in GOROOT, io listed as stale")
}

// Issue 4104.
func TestGoTestWithPackageListedMultipleTimes(t *testing.T) {
tooSlow(t)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Tests Issue #12690

[gccgo] skip 'gccgo does not have GOROOT'

! stale runtime
! stale os
! stale io

env GOROOT=$GOROOT'/'

! stale runtime
! stale os
! stale io

0 comments on commit bec91ce

Please sign in to comment.