-
Notifications
You must be signed in to change notification settings - Fork 17.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cmd/go/internal/modload: report errors explicitly from Lookup
Previously, we reported errors directly in (*loader).load via base.Errorf. Unfortunately, (*loader).load can be called from contexts in which such errors should not be considered fatal, such as by load.PackagesAndErrors. Instead, we save the errors in pkg.err and modify Lookup to return that error. This change is a bit awkward: we end up suppressing a "no Go files" error for packages at the root of newly-imported modules, even if they really do contain source files. I believe that that's due to a special-case lookup for modules in the build list, which allows us to "validate" imports for modules in the build list even though we haven't actually downloaded their sources (or verified that they actually contain the requested package). The fix for that issue is in the change that follows this one. Fixes #26602. Change-Id: I16f00ceb143fbb797cfc3cb07fd08aeb6154575b Reviewed-on: https://go-review.googlesource.com/127936 Run-TryBot: Bryan C. Mills <[email protected]> Reviewed-by: Russ Cox <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
- Loading branch information
Bryan C. Mills
committed
Aug 9, 2018
1 parent
79bf795
commit a1cbbe0
Showing
8 changed files
with
104 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters