Skip to content

Commit

Permalink
runtime/pprof: document labels bug
Browse files Browse the repository at this point in the history
Currently only CPU profile utilizes tag information.
This change documents that fact
  • Loading branch information
komuw committed Aug 24, 2018
1 parent 4363c98 commit 53115b4
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/runtime/pprof/label.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ func WithLabels(ctx context.Context, labels LabelSet) context.Context {
// Labels takes an even number of strings representing key-value pairs
// and makes a LabelSet containing them.
// A label overwrites a prior label with the same key.
// BUG(hyangah): Currently only CPU profile utilizes labels information..
// See https://github.com/golang/go/issues/23458 for details.
func Labels(args ...string) LabelSet {
if len(args)%2 != 0 {
panic("uneven number of arguments to pprof.Labels")
Expand Down

0 comments on commit 53115b4

Please sign in to comment.