Skip to content

Commit

Permalink
test: re-enable rotate tests
Browse files Browse the repository at this point in the history
Memory usage has been reduced.
The tests are still slow,
but that is issue #10571.

/usr/bin/time shows significant variation
in the peak memory usage compiling with tip.
This is unsurprising, given GC.

Using Go 1.4.2, memory is stable at 410mb.
Using tip at d2ee09298,
memory ranges from 470mb (+15%) to 534mb (+30%),
with a mean of 504mb (+23%), with n=50.

Fixes #9933.

Change-Id: Id31f3ae086ec324abf70e8f1a8044c4a0c27e274
Reviewed-on: https://go-review.googlesource.com/10211
Reviewed-by: Brad Fitzpatrick <[email protected]>
  • Loading branch information
josharian committed May 28, 2015
1 parent 596bb76 commit 3ba6387
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 8 deletions.
2 changes: 0 additions & 2 deletions test/rotate0.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// skip

// runoutput ./rotate.go

// Copyright 2013 The Go Authors. All rights reserved.
Expand Down
2 changes: 0 additions & 2 deletions test/rotate1.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// skip

// runoutput ./rotate.go

// Copyright 2013 The Go Authors. All rights reserved.
Expand Down
2 changes: 0 additions & 2 deletions test/rotate2.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// skip

// runoutput ./rotate.go

// Copyright 2013 The Go Authors. All rights reserved.
Expand Down
2 changes: 0 additions & 2 deletions test/rotate3.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// skip

// runoutput ./rotate.go

// Copyright 2013 The Go Authors. All rights reserved.
Expand Down

0 comments on commit 3ba6387

Please sign in to comment.