crypto/internal/cryptotest: skip TestAllocations on s390x

TestXAESAllocations fails like #70448, and crypto/rand's fails in FIPS mode. We can't keep chasing these without even a LUCI builder. Updates #67307 Change-Id: I5d0edddf470180a321dec55cabfb018db62eb940 Reviewed-on: https://go-review.googlesource.com/c/go/+/636055 Auto-Submit: Filippo Valsorda <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
golang · Dec 13, 2024 · 08725f9 · 08725f9
1 parent 1cbfe8c
commit 08725f9
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/crypto/internal/cryptotest/allocations.go b/src/crypto/internal/cryptotest/allocations.go
@@ -32,6 +32,12 @@ func SkipTestAllocations(t *testing.T) {
 		t.Skip("skipping allocations test on plan9")
 	}
 
+	// s390x deviates from other assembly implementations and is very hard to
+	// test due to the lack of LUCI builders. See #67307.
+	if runtime.GOARCH == "s390x" {
+		t.Skip("skipping allocations test on s390x")
+	}
+
 	// Some APIs rely on inliner and devirtualization to allocate on the stack.
 	testenv.SkipIfOptimizationOff(t)
 }