Skip to content
This repository has been archived by the owner on Jan 16, 2021. It is now read-only.

Add Rich data for GitLab.com as code provider #658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZJvandeWeg
Copy link

When packages were searched for and displayed, platforms like GitHub and
Bitbucket had slightly better data presentation. For example the number
of stars a project has.

Additionally, the fallback Git provider that was being used for GitLab,
leverages git ls-remote and git fetch to determine what blobs are in
a tree, and what subdirectories. This combination of requests is much
slower than the 3 API calls done now.

When packages were searched for and disployed, platforms like GitHub and
Bitbucket had slightly better data presentation. For example the number
of stars a project has.

Additionally, the fallback Git provider that was being used for GitLab,
leverages `git ls-remote` and `git fetch` to determine what blobs are in
a tree, and what subdirectories. This combination of requests is much
slower than the 3 API calls done now.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ZJvandeWeg
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Nov 5, 2019
@gopherbot
Copy link

This PR (HEAD: 11db952) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/205417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/205417.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/205417.
After addressing review feedback, remember to publish your drafts!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants