-
Notifications
You must be signed in to change notification settings - Fork 265
Add Rich data for GitLab.com as code provider #658
base: master
Are you sure you want to change the base?
Conversation
When packages were searched for and disployed, platforms like GitHub and Bitbucket had slightly better data presentation. For example the number of stars a project has. Additionally, the fallback Git provider that was being used for GitLab, leverages `git ls-remote` and `git fetch` to determine what blobs are in a tree, and what subdirectories. This combination of requests is much slower than the 3 API calls done now.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: 11db952) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/gddo/+/205417 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/205417. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/205417. |
When packages were searched for and displayed, platforms like GitHub and
Bitbucket had slightly better data presentation. For example the number
of stars a project has.
Additionally, the fallback Git provider that was being used for GitLab,
leverages
git ls-remote
andgit fetch
to determine what blobs are ina tree, and what subdirectories. This combination of requests is much
slower than the 3 API calls done now.