Skip to content
This repository has been archived by the owner on Jan 16, 2021. It is now read-only.

FIX: Missing HSTS-header #562

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlphaWong
Copy link

ADD HSTS header to godoc.org

Please review my changes

Related

golang/go#26162

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/122195.
After addressing review feedback, remember to publish your drafts!

@AlphaWong AlphaWong force-pushed the fix/HSTS-header branch 3 times, most recently from 4104bd1 to 86c197d Compare July 4, 2018 04:45
@gopherbot
Copy link

Message from Akhil Indurti:

Patch Set 4:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/122195.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alpha WONG:

Patch Set 5:

Patch Set 4:

(2 comments)

I change it according to your review


Please don’t reply on this GitHub thread. Visit golang.org/cl/122195.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Akhil Indurti:

Patch Set 6:

(2 comments)

LGTM, but I haven't reviewed for godoc.org before so I'll ping Brad.


Please don’t reply on this GitHub thread. Visit golang.org/cl/122195.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alpha WONG:

Patch Set 6:

Patch Set 6:

(2 comments)

LGTM, but I haven't reviewed for godoc.org before so I'll ping Brad.

Sure, let me clear it up.
thx


Please don’t reply on this GitHub thread. Visit golang.org/cl/122195.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 24958:

Patch Set 7:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/122195.
After addressing review feedback, remember to publish your drafts!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants