This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
rename hoard to dep #164
Merged
rename hoard to dep #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adg
reviewed
Jan 25, 2017
| return m, nil, nil | ||
| } | ||
|
|
||
| func (a analyzer) Info() (name string, version *semver.Version) { | ||
| v, _ := semver.NewVersion("v0.0.1") | ||
| return "hoard", v | ||
| return "deb", v |
adg
reviewed
Jan 25, 2017
| func (a analyzer) DeriveManifestAndLock(path string, n gps.ProjectRoot) (gps.Manifest, gps.Lock, error) { | ||
| // TODO: If we decide to support other tools manifest, this is where we would need |
There was a problem hiding this comment.
The commit description should also mention that you've adjusted some comments.
|
Thanks - we need to do this (doh that we forgot to do it before), but it's going to have the unfortunate side effect of changing all the memos in the tests. Nothing to do about that except copy the results from the actual output to the wanted output. |
|
Memos and other comments are fixed, PTAL. |
|
I suspect the appveyor error was probably due to what's fixed in #157 |
|
issue subject? |
|
No prob. |
|
i hear that closing and reopening might kick the checks...let's see if it does. |
|
ding ding ding! |
krisnova
pushed a commit
to krisnova/dep
that referenced
this pull request
Apr 21, 2017
Introduce monitoredCmd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change also includes minor style fixes for some comments.