This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
fix '|&' pipe on travis osx vm #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koichi Shiraishi <[email protected]>
'|&' is despite syntax error on travis osx vm, but test passes. Fix avoid sdboyer/gps testdata error message using 2>&1 Signed-off-by: Koichi Shiraishi <[email protected]>
|
ah, why failed AppVeyor? |
|
AppVeyor is flacky for testing. |
Merged
|
This LGTM thanks! |
krisnova
pushed a commit
to krisnova/dep
that referenced
this pull request
Apr 21, 2017
This *should* solve the issues raised in golang#156. I can't replicate the bug in tests, though, so I'm not fully sure. Pretty disquieting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterbranch was failing the travis test for a while because ofstatus_test.goformat error bygofmt. just formatted.And mainly, this PR for
|&pipe is despite syntax error on travis osx vm, but test passes. (maybe due to differencesbashversion?)See https://ember-canary.travis-ci.org/golang/dep/jobs/195026617#L77-L79
This will be a problem in the future, so fixed it together.
This pull request will pass travis test, but conflicted #143.
So if merge #143 first, I will rebase and fix pull request to only fixed
.travis.yml.