This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
status: LATEST should be of the same type as VERSION #1515
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| [{"ProjectRoot":"github.com/sdboyer/deptest","Constraint":"^0.8.0","Version":"v0.8.0","Revision":"ff2948a2ac8f538c4ecd55962e919d1e13e74baf","Latest":"3f4c3bea144e112a69bbe5d8d01c1b09a544253f","PackageCount":1},{"ProjectRoot":"github.com/sdboyer/deptestdos","Constraint":"v2.0.0","Version":"v2.0.0","Revision":"5c607206be5decd28e6263ffffdcee067266015e","Latest":"5c607206be5decd28e6263ffffdcee067266015e","PackageCount":1}] | ||
| [{"ProjectRoot":"github.com/sdboyer/deptest","Constraint":"^0.8.0","Version":"v0.8.0","Revision":"ff2948a2ac8f538c4ecd55962e919d1e13e74baf","Latest":"v0.8.1","PackageCount":1},{"ProjectRoot":"github.com/sdboyer/deptestdos","Constraint":"v2.0.0","Version":"v2.0.0","Revision":"5c607206be5decd28e6263ffffdcee067266015e","Latest":"v2.0.0","PackageCount":1}] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| PROJECT CONSTRAINT VERSION REVISION LATEST PKGS USED | ||
| github.com/sdboyer/deptest ^0.8.0 v0.8.0 ff2948a 3f4c3be 1 | ||
| github.com/sdboyer/deptestdos v2.0.0 v2.0.0 5c60720 5c60720 1 | ||
| PROJECT CONSTRAINT VERSION REVISION LATEST PKGS USED | ||
| github.com/sdboyer/deptest ^0.8.0 v0.8.0 ff2948a v0.8.1 1 | ||
| github.com/sdboyer/deptestdos v2.0.0 v2.0.0 5c60720 v2.0.0 1 |
6 changes: 3 additions & 3 deletions
6
cmd/dep/testdata/harness_tests/status/override_constraint/stdout.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| PROJECT CONSTRAINT VERSION REVISION LATEST PKGS USED | ||
| github.com/sdboyer/deptest v0.8.1 (override) v0.8.1 3f4c3be 3f4c3be 1 | ||
| github.com/sdboyer/deptestdos v2.0.0 v2.0.0 5c60720 5c60720 1 | ||
| PROJECT CONSTRAINT VERSION REVISION LATEST PKGS USED | ||
| github.com/sdboyer/deptest v0.8.1 (override) v0.8.1 3f4c3be v0.8.1 1 | ||
| github.com/sdboyer/deptestdos v2.0.0 v2.0.0 5c60720 v2.0.0 1 |
6 changes: 3 additions & 3 deletions
6
cmd/dep/testdata/harness_tests/status/revision_constraint/stdout.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| PROJECT CONSTRAINT VERSION REVISION LATEST PKGS USED | ||
| github.com/sdboyer/deptest v1.0.0 v1.0.0 ff2948a ff2948a 1 | ||
| github.com/sdboyer/deptestdos a0196ba a0196ba 1 | ||
| PROJECT CONSTRAINT VERSION REVISION LATEST PKGS USED | ||
| github.com/sdboyer/deptest v1.0.0 v1.0.0 ff2948a v1.0.0 1 | ||
| github.com/sdboyer/deptestdos a0196ba a0196ba 1 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't account for plain versions - those will still show up with a rev. Can deal with it later, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we enter this version's updatability check block only for non-rev and non-plain version. LATEST for plain version would be empty. I think that's the right behavior.