Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

ensure: Make -no-vendor combined with -dry-run fail when Gopkg.lock is outdated #1256

Merged
merged 7 commits into from
Oct 17, 2017

Conversation

JelteF
Copy link
Contributor

@JelteF JelteF commented Oct 10, 2017

What does this do / why do we need it?

It makes dep ensure -no-vendor -dry-run fail when changes would be made to
Gopkg.lock.

What should your reviewer look out for in this PR?

This is my first PR so I'm not sure if everything is up to standards.

Do you need help or clarification on anything?

No.

Which issue(s) does this PR fix?

fixes #950

@JelteF JelteF requested a review from ibrasho as a code owner October 10, 2017 17:11
@JelteF JelteF requested a review from sdboyer as a code owner October 10, 2017 17:12
@JelteF
Copy link
Contributor Author

JelteF commented Oct 11, 2017

Could someone restart the appveyor run? It seems to have failed randomly.

Copy link
Member

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good! but, needs a test case 😄

@JelteF
Copy link
Contributor Author

JelteF commented Oct 13, 2017

Added tests

Copy link
Collaborator

@ibrasho ibrasho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantics for "check if imports/Gopkg.toml are in sync with Gopkg.lock" command
4 participants