This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
fix(status): skip ignored pkgs in missing pkgs chk #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
status-mismatch-ignore
branch
from
b143053 to
97a0bcd
Compare
This change skips the root packages from missing package check if there's a path to the corresponding package in manifest's ignored list. `digestMismatch` is removed from `runStatusAll()`. When there's a digest mismatch, it's an error. And we already log to stderr but never returned an actual error. `errInputDigestMismatch` is now returned as error when there's a digest mismatch. Some refactoring in how we handle the returned info from `runStatusAll()` and show the errors and their solutions.
darkowlzz
force-pushed
the
status-mismatch-ignore
branch
from
97a0bcd to
293efa0
Compare
This change removes the usage of IgnoredPackages() separately and passes the same to ToReachMap(), which returns the packages with all ignoring rules applied.
darkowlzz
force-pushed
the
status-mismatch-ignore
branch
from
293efa0 to
7c5da12
Compare
jmank88
approved these changes
Sep 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This change skips the root packages from missing package check if
there's a path to the corresponding package in manifest's ignored list.
digestMismatchis removed fromrunStatusAll(). When there'sa digest mismatch, it's an error. And we already log to stderr but never
returned an actual error.
errInputDigestMismatchis now returned as errorwhen there's a digest mismatch.
Some refactoring in how we handle the returned info from
runStatusAll()and show the errors and their solutions.
What should your reviewer look out for in this PR?
The refactoring and error handling.
Do you need help or clarification on anything?
No.
Which issue(s) does this PR fix?
fixes #1193