Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Replace import path 'Sirupsen/logrus' with 'sirupsen/logrus' #1122

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

muesli
Copy link
Contributor

@muesli muesli commented Sep 4, 2017

Use the new canonical project URL (note the lowercase 's') for logrus to prevent duplicate checkouts & imports of logrus.

See: sirupsen/logrus#384

Use the new canonical project URL (note the lowercase 's') for logrus to prevent duplicate checkouts & imports of logrus.

See: sirupsen/logrus#384
@muesli muesli requested a review from sdboyer as a code owner September 4, 2017 21:57
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@muesli
Copy link
Contributor Author

muesli commented Sep 4, 2017

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 4, 2017
@sdboyer
Copy link
Member

sdboyer commented Sep 5, 2017

hah! funny timing.

yes, we're definitely aware of the problem - see #1079, sirupsen/logrus#451 (comment). this actual instance of Sirupsen has no risk of being harmful, as it's not a real import statement. but still, it doesn't hurt us to send all the right signals!

@sdboyer sdboyer merged commit 59c9596 into golang:master Sep 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants