-
Notifications
You must be signed in to change notification settings - Fork 1k
Update out-of-sync error message in ensure #1109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"plain ensure" is a bite vague, especially to anyone who isn't a native English speaker. Perhaps we could just tell them exactly which command to run?
Gopkg.lock is out of sync with either Gopkg.toml or the project code. First run "dep ensure" to resync them first, and then run "dep ensure -add ..."
agreed with @carolynvs. also, s/the project code/your project's imports/ - equally succinct, but more specific. |
oh, also, drop the "either" - it's one or the other, or both. |
Does this work?
|
Signed-off-by: Ibrahim AshShohail <[email protected]>
51d77e8
to
8a8d73c
Compare
I like it! 👍 |
Hi @carolynvs and @ibrasho, I personally would like the ability to run |
jumping in to note that i discussed this with @akutz the other day on the phone, and decided that i was probably being a bit too strict about not allowing users to do this. so i'm cool with relaxing that requirement - though it's still probably worth having a warning. |
What does this do / why do we need it?
Update out of sync error message from:
to:
for both add and update.
Do you need help or clarification on anything?
Any better suggestions?
Which issue(s) does this PR fix?
fixes #1104