This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
add script to check if changes to vendor are valid #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested on #97 and it fails, which is correct |
|
ugh idk why appveyor is testing here |
sdboyer
reviewed
Jan 17, 2017
| @@ -0,0 +1,48 @@ | |||
| #!/bin/bash | |||
| # Copyright 2009 The Go Authors. All rights reserved. | |||
sdboyer
reviewed
Jan 17, 2017
| if [ ${#files[@]} -gt 0 ]; then | ||
| # We run ensure to and see if we have a diff afterwards | ||
| go build | ||
| ./hoard ensure |
There was a problem hiding this comment.
this is fine for now, but just leaving a note to say that this is exactly the kind of validation that IMO we should have a more direct command for: "does the manifest match the lock? (memo)" "does the lock match vendor?"
There was a problem hiding this comment.
totally i believe status with format should do this
Signed-off-by: Jess Frazelle <[email protected]>
|
merging as this is pretty standard and just bash |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #101