Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

tests: stop wiping memo #59

Closed
sdboyer opened this issue Dec 23, 2016 · 3 comments · Fixed by #97
Closed

tests: stop wiping memo #59

sdboyer opened this issue Dec 23, 2016 · 3 comments · Fixed by #97
Labels
bug
Milestone
Go public

Comments

@sdboyer
Copy link
Member

sdboyer commented Dec 23, 2016

Gotta do it sooner or later, preferably sooner
@sdboyer
Copy link
Member Author

sdboyer commented Dec 30, 2016 •
edited
Loading

memo was being computed incorrectly (again) - stdlib imports were being incorporated. that's now fixed, so we're one step closer to being able to do this (once new version of gps comes in)

@jessfraz
Copy link
Contributor

we can do this after #97 right?

@jessfraz jessfraz changed the title Stop wiping memo in tests tests: stop wiping memo Jan 17, 2017
@jessfraz jessfraz added this to the Go public milestone Jan 17, 2017
@jessfraz jessfraz added the bug label Jan 17, 2017
@sdboyer sdboyer mentioned this issue Jan 18, 2017
Merged
@sdboyer
Copy link
Member Author

sdboyer commented Jan 18, 2017

yeah, actually, #97 just goes ahead and fixes this; it should auto-close once we merge that.

krisnova pushed a commit to krisnova/dep that referenced this issue Apr 21, 2017
@sdboyer
Remove Manifest.Name() method
6fcc2a9 
It seems to have been redundant in all cases, and just a source for
potential conflict errors. Fixes golang#59.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Go public
Development

Successfully merging a pull request may close this issue.

Chase improvements to input hashing in gps
2 participants
@sdboyer @jessfraz