Skip to content

Commit

Permalink
internal/task/releaselet: add logging to MSI building
Browse files Browse the repository at this point in the history
Building the MSIs can take quite a while. Add some logging to keep the
watchdog happy.

For golang/go#54134.

Change-Id: I6178323f6e34a6ecd409370e9e396f683a6cdb9f
Reviewed-on: https://go-review.googlesource.com/c/build/+/420542
Reviewed-by: Jenny Rakoczy <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
Auto-Submit: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
  • Loading branch information
heschi authored and gopherbot committed Aug 2, 2022
1 parent 58d82ee commit c752abf
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions internal/task/releaselet/releaselet.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ func windowsMSI() error {
// Install Wix tools.
wix := filepath.Join(cwd, "wix")
defer os.RemoveAll(wix)
fmt.Fprintln(os.Stderr, "installing wix")
switch runtime.GOARCH {
default:
if err := installWix(wixRelease311, wix); err != nil {
Expand All @@ -77,6 +78,7 @@ func windowsMSI() error {
}

// Gather files.
fmt.Fprintln(os.Stderr, "running wix heat")
goDir := filepath.Join(cwd, "go")
appfiles := filepath.Join(win, "AppFiles.wxs")
if err := runDir(win, filepath.Join(wix, "heat"),
Expand Down Expand Up @@ -108,6 +110,7 @@ func windowsMSI() error {
// Build package.
verMajor, verMinor, verPatch := splitVersion(version)

fmt.Fprintln(os.Stderr, "running wix candle")
if err := runDir(win, filepath.Join(wix, "candle"),
"-nologo",
"-arch", msArch(),
Expand All @@ -125,6 +128,7 @@ func windowsMSI() error {
if err := os.Mkdir(msi, 0755); err != nil {
return err
}
fmt.Fprintln(os.Stderr, "running wix light")
return runDir(win, filepath.Join(wix, "light"),
"-nologo",
"-dcl:high",
Expand Down

0 comments on commit c752abf

Please sign in to comment.