Skip to content

Commit

Permalink
dashboard: enable linux/loong64 builder on 1.19 release branches
Browse files Browse the repository at this point in the history
It made sense for the linux/loong64 builder to only test the main branch
during the port's development. Now that it's complete, update the policy
to test all supported Go versions (starting with Go 1.19, when the port
was added) instead of just tip.

This will increase the volume of work for the builder by some amount,
hopefully that's fine, it seems to have enough resources to handle it.

Updates golang/go#54222.

Change-Id: Ic774b9890fc4826e56613f360d6edd03f50e3deb
Reviewed-on: https://go-review.googlesource.com/c/build/+/459876
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: abner chenc <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: David Chase <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
  • Loading branch information
dmitshur authored and gopherbot committed Jan 3, 2023
1 parent 59e4df6 commit baa973b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
6 changes: 4 additions & 2 deletions dashboard/builders.go
Original file line number Diff line number Diff line change
Expand Up @@ -2833,8 +2833,10 @@ func init() {
},
buildsRepo: func(repo, branch, goBranch string) bool {
switch repo {
case "go", "net", "sys":
return branch == "master" && goBranch == "master"
case "go":
return atLeastGo1(goBranch, 19)
case "net", "sys":
return branch == "master" && atLeastGo1(goBranch, 19)
default:
return false
}
Expand Down
4 changes: 4 additions & 0 deletions dashboard/builders_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,11 @@ func TestBuilderConfig(t *testing.T) {
{b("linux-amd64", "net"), both},

{b("linux-loong64-3a5000", "go"), onlyPost},
{b("[email protected]", "go"), onlyPost},
{b("[email protected]", "go"), none}, // Go 1.18 doesn't support this port.
{b("linux-loong64-3a5000", "sys"), onlyPost},
{b("[email protected]", "sys"), onlyPost},
{b("[email protected]", "sys"), none},
{b("linux-loong64-3a5000", "net"), onlyPost},

// OpenBSD 6.8.
Expand Down

0 comments on commit baa973b

Please sign in to comment.