devapp/owners: add owners for golang.org/x/tools

This change is part of an effort to improve the maintenance of the x/tools repository. Historically, we have not had well-defined owners for tools, which has caused a number of CLs to slip through the cracks. I've added as many owners here as I know or can guess. Please correct me if I'm mistaken. For any package that doesn't seem to have owners or that I wasn't sure about, I've just listed "defaultToolsOwners" as a placeholder so that we don't forget about those packages. I've added everyone that is a part of this change as a reviewer to make sure they are aware of it. Please +1 to indicate that you are OK with the changes. Change-Id: I6a2d7bb48d2c72910a1407ce6f10cc1c03288d77 Reviewed-on: https://go-review.googlesource.com/c/build/+/228217 Run-TryBot: Rebecca Stambler <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Andrew Bonventre <[email protected]>
golang · Apr 20, 2020 · 5910a27 · 5910a27
1 parent 7858236
commit 5910a27
Show file tree

Hide file tree

Showing 2 changed files with 136 additions and 6 deletions.
diff --git a/devapp/owners/table.go b/devapp/owners/table.go
@@ -35,12 +35,15 @@ var (
 	dvyukov      = gh("dvyukov")
 	empijei      = gh("empijei")
 	filippo      = gh("FiloSottile")
+	findleyr     = gh("findleyr")
 	gri          = gh("griesemer")
 	hanwen       = gh("hanwen")
+	heschik      = gh("heschik")
 	hyangah      = gh("hyangah")
 	iant         = gh("ianlancetaylor")
 	iancottrell  = gh("ianthehat")
 	jayconrod    = gh("jayconrod")
+	jba          = gh("jba")
 	jbd          = gh("rakyll")
 	joetsai      = gh("dsnet")
 	josharian    = gh("josharian")
@@ -61,6 +64,7 @@ var (
 	neelance     = gh("neelance")
 	pearring     = gh("pearring")
 	r            = gh("robpike")
+	rakoczy      = gh("toothrot")
 	rsc          = gh("rsc")
 	rstambler    = gh("stamblerre")
 	sameer       = gh("Sajmani")
@@ -650,41 +654,161 @@ var entries = map[string]*Entry{
 		Primary: []Owner{mpvl},
 	},
 
+	"tools/benchmark": toolsOwners,
+	"tools/blog":      toolsOwners,
 	"tools/cmd/compilebench": {
 		Secondary: []Owner{josharian},
 	},
 	"tools/cmd/bundle": {
 		Primary: []Owner{adonovan},
 	},
+	"tools/cmd/auth": {
+		Primary:   []Owner{bcmills},
+		Secondary: []Owner{jayconrod, matloob},
+	},
 	"tools/cmd/godoc": {
 		Primary:   []Owner{dmitshur},
 		Secondary: []Owner{agnivade, bradfitz, gri, kevinburke},
 	},
 	"tools/cmd/goimports": {
-		Primary: []Owner{bradfitz},
+		Primary:   []Owner{heschik},
+		Secondary: []Owner{bradfitz},
 	},
-	"tools/cmd/gopls": {
-		Primary: []Owner{rstambler, iancottrell},
+	"tools/cmd/present2md": {
+		Primary: []Owner{rsc},
 	},
 	"tools/cmd/stringer": {
 		Secondary: []Owner{mvdan},
 	},
+	"tools/container": toolsOwners,
+	"tools/cover":     toolsOwners,
+	"tools/go/analysis": {
+		Primary: []Owner{matloob},
+	},
+	"tools/go/ast": {
+		Primary:   []Owner{gri},
+		Secondary: []Owner{josharian, dmitshur},
+	},
+	"tools/go/buildutil": {
+		Primary:   []Owner{bcmills, jayconrod, matloob},
+		Secondary: []Owner{dmitshur},
+	},
+	"tools/go/callgraph": toolsOwners,
+	"tools/go/cfg":       toolsOwners,
+	"tools/go/expect": {
+		Primary: []Owner{iancottrell},
+	},
+	"tools/go/gccgoexportdata": toolsOwners,
+	"tools/go/gcexportdata": {
+		Primary: []Owner{rstambler, gri},
+	},
+	"tools/go/internal/cgo":           toolsOwners,
+	"tools/go/internal/gccgoimporter": toolsOwners,
+	"tools/go/internal/gcimporter": {
+		Primary: []Owner{rstambler, gri},
+	},
+	"tools/go/internal/packagesdriver": {
+		Primary: []Owner{matloob},
+	},
+	"tools/go/loader": {
+		Primary: []Owner{matloob},
+	},
 	"tools/go/packages": {
 		Primary: []Owner{matloob},
 	},
+	"tools/go/packages/packagestest": {
+		Primary: []Owner{iancottrell},
+	},
+	"tools/go/pointer": toolsOwners,
+	"tools/go/ssa": {
+		Primary: []Owner{findleyr},
+	},
+	"tools/go/types": toolsOwners,
+	"tools/go/vcs": {
+		Primary:   []Owner{dmitshur},
+		Secondary: []Owner{bcmills, jayconrod, matloob},
+	},
 	"tools/godoc": {
 		Primary: []Owner{dmitshur},
 	},
-	"tools/internal/lsp": {
-		Primary: []Owner{rstambler, iancottrell},
+	"tools/gopls": {
+		Primary:   []Owner{rstambler},
+		Secondary: []Owner{iancottrell},
+	},
+	"tools/imports": {
+		Primary: []Owner{heschik},
+	},
+	"tools/internal/analysisinternal": {
+		Primary:   []Owner{rstambler},
+		Secondary: []Owner{matloob},
+	},
+	"tools/internal/apidiff": {
+		Primary:   []Owner{jba},
+		Secondary: []Owner{jayconrod, matloob, bcmills},
 	},
-	"tools": {
+	"tools/internal/fastwalk": {
+		Primary: []Owner{heschik},
+	},
+	"tools/internal/gocommand": {
+		Primary: []Owner{heschik},
+	},
+	"tools/internal/gopathwalk": {
+		Primary: []Owner{heschik},
+	},
+	"tools/internal/imports": {
+		Primary: []Owner{heschik},
+	},
+	"tools/internal/jsonrpc2": {
 		Primary:   []Owner{iancottrell},
+		Secondary: []Owner{findleyr, jba},
+	},
+	"tools/internal/lsp": {
+		Primary:   []Owner{rstambler},
+		Secondary: []Owner{iancottrell},
+	},
+	"tools/internal/memoize": {
+		Primary: []Owner{iancottrell},
+	},
+	"tools/internal/packagesinternal": {
+		Primary:   []Owner{rstambler},
 		Secondary: []Owner{matloob},
 	},
+	"tools/internal/proxydir": {
+		Primary: []Owner{findleyr},
+	},
+	"tools/internal/span": {
+		Primary:   []Owner{iancottrell},
+		Secondary: []Owner{heschik},
+	},
+	"tools/internal/telemetry": {
+		Primary:   []Owner{iancottrell},
+		Secondary: []Owner{findleyr},
+	},
+	"tools/internal/testenv": {
+		Primary: []Owner{bcmills},
+	},
+	"tools/internal/tool": {
+		Primary: []Owner{iancottrell},
+	},
+	"tools/internal/xcontext": {
+		Primary: []Owner{iancottrell},
+	},
+	"tools/playground": {
+		Primary: []Owner{andybons, rakoczy},
+	},
+	"tools/present": {
+		Primary: []Owner{rsc},
+	},
+	"tools/refactor": toolsOwners,
+	"tools/txtar": {
+		Primary: []Owner{jayconrod, bcmills, matloob},
+	},
+	"tools": toolsOwners,
+
 	"playground": {
 		Secondary: []Owner{},
 	},
+
 	"website": {
 		Primary:   []Owner{dmitshur},
 		Secondary: []Owner{cnoellekb, andybons},
@@ -702,6 +826,11 @@ var entries = map[string]*Entry{
 	},
 }
 
+var toolsOwners = &Entry{
+	Primary:   []Owner{iancottrell},
+	Secondary: []Owner{matloob},
+}
+
 var wasmOwners = &Entry{
 	Primary: []Owner{neelance, cherryyz},
 }
diff --git a/internal/gophers/gophers.go b/internal/gophers/gophers.go
@@ -2351,6 +2351,7 @@ func init() {
 	addPerson("Rob Strong", "[email protected]")
 	addPerson("Robert Anthony Bellamy", "[email protected]")
 	addPerson("Robert Bittle", "[email protected]")
+	addPerson("Robert Findley", "[email protected]", "@findleyr")
 	addPerson("Robert Figueiredo", "[email protected]", "@robfig")
 	addPerson("Robert Gogolok", "[email protected]")
 	addPerson("Robert Griesemer", "[email protected]", "5210@62eb7196-b449-3ce5-99f1-c037f21e1705")