prevent net/url encoding the user password

[bcho]

This is a cherry-pick fix from mattes/migrate#324. This should fix mattes/migrate#256

cc @RyanDeng

---

According to net/url

// A URL represents a parsed URL (technically, a URI reference).
//
// The general form represented is:
//
//	[scheme:][//[userinfo@]host][/]path[?query][#fragment]
//
// URLs that do not start with a slash after the scheme are interpreted as:
//
//	scheme:opaque[?query][#fragment]
//

If the url starts with a slash after the scheme, the url.String() func will do url encode for the userinfo. In this case, password that has non-alphanumeric char will be url encoded and mysql auth will fail.

Probably the best fix should be in Open() func of database/driver.go. However I'm using mysql and not familiar with other drivers, so make a tiny fix in the mysql driver

[coveralls]

Pull Request Test Coverage Report for Build 116

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 49.522%

---

Totals
Change from base Build 115:	0.0%
Covered Lines:	828
Relevant Lines:	1672

---

💛 - Coveralls

[dhui]

Agreed. For now, fixing every db driver is the right approach.
But the better long term change is to change the Open() method in the Driver interface to take a url.URL instead of a string but that's a backwards incompatible change.

[dhui]

@bcho @RyanDeng I'll probably have to revert this PR as it's breaking for users who have @ in their db username. Any encoding interplay between migrate DB drivers and the underlying DB driver will have to be dealt with in the driver. The best approach in this case may be to "re-encode" URL and make the url parts compatible with the MySQL DSN.

A future release of the MySQL driver shouldn't have the same encoding problems: go-sql-driver/mysql#591
There may always be encoding issues when using url.Parse() directly with the MySQL driver: go-sql-driver/mysql#460 (comment)

[bcho]

ok, that makes sense

…

On Tue, Jul 24, 2018, 3:10 PM Dale Hui ***@***.***> wrote: @bcho <https://github.com/bcho> @RyanDeng <https://github.com/RyanDeng> I'll probably have to revert this PR as it's breaking for users who have @ in their db username. Any encoding interplay between migrate DB drivers and the underlying DB driver will have to be dealt with in the driver. The best approach in this case may be to "re-encode" URL and make the url parts compatible with the MySQL DSN. A future release of the MySQL driver *shouldn't* have the same encoding problems: go-sql-driver/mysql#591 <go-sql-driver/mysql#591> There may always be encoding issues when using url.Parse() directly with the MySQL driver: go-sql-driver/mysql#460 (comment) <go-sql-driver/mysql#460 (comment)> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4jTlffMMq6w2ilDHKveC-ufzHo15wnks5uJshdgaJpZM4U8_xj> .