Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document drop -f in migrate -help #459

Merged
merged 2 commits into from
Oct 17, 2020

Conversation

neomantra
Copy link
Contributor

I started testing my migrations in CI/CD -- both up and down.

I wanted to bypass the Are you sure you want to drop the entire database schema? [y/N] and couldn't figure out how.

Then I found it in the code.

This -f feature is not documented in the migrate -help usage. I added the phrase (use -f to bypass confirmation).

Another option is to try to print out the Golang flag options, but that's a much bigger change and the simple usage doc is sufficient.

@coveralls
Copy link

coveralls commented Oct 16, 2020

Pull Request Test Coverage Report for Build 900

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 55.629%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/cli/main.go 0 2 0.0%
Totals Coverage Status
Change from base Build 895: -0.01%
Covered Lines: 3044
Relevant Lines: 5472

💛 - Coveralls

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@@ -54,7 +54,7 @@ Commands:
goto V Migrate to version V
up [N] Apply all or N up migrations
down [N] Apply all or N down migrations
drop Drop everything inside database
drop Drop everything inside database (use -f to bypass confirmation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the existing format. e.g. drop [-f]
See create, up, and down for examples

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback

@dhui dhui merged commit f76b94a into golang-migrate:master Oct 17, 2020
@neomantra neomantra deleted the force-drop-docs branch October 30, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants