-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bitbucket Cloud Support as source #450
Conversation
Pull Request Test Coverage Report for Build 873
💛 - Coveralls |
Pull Request Test Coverage Report for Build 876
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
|
||
b := &Bitbucket{} | ||
|
||
d, err := b.Open("bitbucket://" + BitbucketTestSecret + "@abhishekbipp/test-migration/migrations/test#master") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setup a public repo to test against
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a public repo.
https://bitbucket.org/abhishekbipp/test-migration/src/master/migrations/test/
source/bitbucket/bitbucket.go
Outdated
} | ||
bi.config.Ref = u.Fragment | ||
|
||
if err := bi.readDirectory(); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call WithInstance()
so there's a single path to instantiate a Bitbucket
struct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!!
In my project, we needed to source the migrations from Bitbucket Cloud.
Implemented the source Driver interface for Bitbucket Cloud, let me know if this can be merged into the codebase.