Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump spanner lib to v1.5.0 #403

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Conversation

dmivankov
Copy link
Contributor

Will enable spanner emulator support
https://cloud.google.com/spanner/docs/emulator#go

Current version supports SPANNER_EMULATOR_HOST but fails at run-time
with spanner permission errors.

Will enable spanner emulator support
https://cloud.google.com/spanner/docs/emulator#go

Current version supports SPANNER_EMULATOR_HOST but fails at run-time
with spanner permission errors.
cloud.google.com/go v0.53.0 // indirect
cloud.google.com/go/spanner v1.2.0
cloud.google.com/go/storage v1.5.0
cloud.google.com/go/spanner v1.5.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this line was changed manually, other changes are from running "go get"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also run go mod tidy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, though still a big diff

@coveralls
Copy link

coveralls commented Jun 9, 2020

Pull Request Test Coverage Report for Build 784

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.38%

Totals Coverage Status
Change from base Build 782: 0.0%
Covered Lines: 2614
Relevant Lines: 4897

💛 - Coveralls

@dmivankov dmivankov requested a review from dhui June 9, 2020 10:41
@dhui dhui merged commit 1f973cc into golang-migrate:master Jun 9, 2020
@wyardley
Copy link
Contributor

Thanks for adding this, btw... was in the middle of checking if the program supported the emulator and found this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants