Add -f option to drop command #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 767
💛 - Coveralls |
Pull Request Test Coverage Report for Build 765
💛 - Coveralls |
dhui
requested changes
May 18, 2020
internal/cli/main.go
Outdated
| } else { | ||
| log.fatal("Aborted dropping the entire database schema") | ||
| dropFlagSet := flag.NewFlagSet("drop", flag.ExitOnError) | ||
| responseYes := dropFlagSet.Bool("y", false, "Drop the entire database schema") |
There was a problem hiding this comment.
Not sure about using -y. Most other CLIs use -f for this behavior.
The flag help text should be more descriptive.
If we use -f, something like Force the drop command by bypassing the confirmation prompt might work.
Any ideas for a short descriptive help text?
There was a problem hiding this comment.
Thanks for your confirmation!
You are certainly right.
I'm sure the help text you wrote is fine too.
I’ve added commits for fix. Could you check it? 🙏
dhui
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This #360 change caused that the y/n prompt will appears when dropping the database, it has made inoperable our database drop job of kubernetes.
I think that the drop command should have
-yoption for CI/CD operations (Of course, we can also use the yes command, but it is so painful).