Dockerization #24
Merged
Dockerization #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhui
requested changes
May 8, 2018
Dockerfile
Outdated
| @@ -0,0 +1,22 @@ | |||
|
|
|||
| FROM golang:1.10-stretch as downloader | |||
There was a problem hiding this comment.
Use
FROM golang:1.10-alpine3.7 AS downloader
RUN apk add --no-cache git gcc musl-dev
That way you won't need glibc below. musl should be compatible with glibc
Dockerfile
Outdated
| go get -u github.com/kshvakov/clickhouse && \ | ||
| GOOS=linux GOARCH=386 go build -a -o build/migrate.linux-386 -ldflags='-X main.Version=$(VERSION)' -tags '$(DATABASE) $(SOURCE)' ./cli | ||
|
|
||
| FROM frolvlad/alpine-glibc |
There was a problem hiding this comment.
Use
FROM alpine:3.7
RUN apk add --no-cache ca-certificates
musl should work instead of glibc and I'd prefer to only depend on official docker images. Also, we'll need the certs for remote sources.
.travis.yml
Outdated
| @@ -7,6 +7,8 @@ go: | |||
|
|
|||
| env: | |||
| - MIGRATE_TEST_CONTAINER_BOOT_TIMEOUT=60 | |||
| - secure: "ENCYRYPTED USERNAME" | |||
There was a problem hiding this comment.
Remove these environment variables for now since it's creating extra TravisCI builds. I'll figure out a way to safely pass in credentials once this PR is merged.
|
To add encrypted variable you should do this (cf https://docs.travis-ci.com/user/environment-variables/#Defining-encrypted-variables-in-.travis.yml) With |
Signed-off-by: Alexandre MARRE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #23
I don't use travis ci but according to the documentation you need to setup environments variable from cli then added hash to .travis.yml ?
Image currently weighs 13.8MB