Statically linked binaries in release packages

[marvell]

Hi there,

could you please recompile latest binaries with statically linking. Current version cannot use in alpine OS.

FROM alpine:latest

ENV MIGRATE_VERSION=3.2.0
RUN set -xe && \
	curl -Ls https://github.com/golang-migrate/migrate/releases/download/v${MIGRATE_VERSION}/migrate.linux-amd64.tar.gz | \
	tar -xz -C /usr/local/bin && \
	mv /usr/local/bin/migrate.linux-amd64 /usr/local/bin/migrate

[dhui]

Thanks for the Dockerfile to test!

Note to self: Try passing the following to go build: -ldflags '-extldflags "-static"'

[dhui]

Will close this issue after the next release

[marvell]

Thanks!

[dhui]

Fixed in v3.3.0

[dolftax]

➜  file ~/code/bin/migrate         
/home/dolftax/code/bin/migrate: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, with debug_info, not stripped
➜  ~/code/bin/migrate -version
3.3.0

[dolftax]

@dhui Not fixed in v3.3.0 // Re-open this?

[dhui]

Weird, the MacOS binary is statically linked but the Linux one isn't... I don't have access to a Windows machine, so I can't verify that binary. My guess is that CGO_ENABLE needs to be set to 0.

MacOS

$ curl -sLO https://github.com/golang-migrate/migrate/releases/download/v3.3.0/migrate.darwin-amd64.tar.gz
$ tar -xzvf migrate.darwin-amd64.tar.gz
x ./migrate.darwin-amd64
$ file migrate.darwin-amd64
migrate.darwin-amd64: Mach-O 64-bit executable x86_64
$ otool -L migrate.darwin-amd64
migrate.darwin-amd64:
$

Linux

$ curl -sLO https://github.com/golang-migrate/migrate/releases/download/v3.3.0/migrate.linux-amd64.tar.gz
$ tar -xzvf migrate.linux-amd64.tar.gz
./migrate.linux-amd64
$ file migrate.linux-amd64
migrate.linux-amd64: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, with debug_info, not stripped
$ ldd migrate.linux-amd64
	linux-vdso.so.1 (0x00007ffe54f73000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fd002d65000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fd002974000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fd002f84000)
$

[dhui]

I've confirmed that CGO_ENABLED=0 ensures that all built binaries are statically linked. This will go out in the next release.

[dolftax]

@dhui Thanks for the heads up. Could you patch it with v3.3.1 ? It is breaking in alpine environments.

If not, will build it myself and push to s3 for now and wait for v3.4.0

[dhui]

@jaipradeesh v3.3.1 uses static builds

MacOS

$ curl -sLO https://github.com/golang-migrate/migrate/releases/download/v3.3.1/migrate.darwin-amd64.tar.gz
$ tar -xzvf migrate.darwin-amd64.tar.gz
x ./migrate.darwin-amd64
$ file migrate.darwin-amd64
migrate.darwin-amd64: Mach-O 64-bit executable x86_64
$ otool -L migrate.darwin-amd64
migrate.darwin-amd64:
$

Linux

$ curl -sLO https://github.com/golang-migrate/migrate/releases/download/v3.3.1/migrate.linux-amd64.tar.gz
$ tar -xzvf migrate.linux-amd64.tar.gz
./migrate.linux-amd64
$ file migrate.linux-amd64
migrate.linux-amd64: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, with debug_info, not stripped
$ ldd migrate.linux-amd64
	not a dynamic executable
$

[dolftax]

Thanks very much Dale.