Use sync.OnceValue for SupportsEd25519 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertakman
approved these changes
Oct 8, 2024
dagood
force-pushed
the
dev/dagood/ed25519-oncevalue
branch
from
cca75db
to
5716806
Compare
karianna
approved these changes
Oct 10, 2024
qmuntal
approved these changes
Oct 10, 2024
bdhill-arista
pushed a commit
to aristanetworks/go-openssl-fips
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed
sync.Oncein the existing code near what #204 changed.sync.OnceValueis a good fit to simplify this code, now that we're able to use it.The only other remaining use of "raw"
Oncein the repo is openssl.go'sinitOnce. It takes a parameter passed from outside the module, so it isn't a good fit forOnceFunc/OnceValue/OnceValuesand should keep usingOnce, IMO.Enable "Hide whitespace" for an easier review.