Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RC4 #117

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Add support for RC4 #117

merged 2 commits into from
Oct 12, 2023

Conversation

qmuntal
Copy link
Collaborator

@qmuntal qmuntal commented Sep 14, 2023

This PR implements the necessary functions to support crypto/rc4.

New benchmark results:

goos: windows
goarch: amd64
pkg: github.com/golang-fips/openssl/v2
cpu: Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz
BenchmarkRC4_128-12      5396026               220.1 ns/op       581.51 MB/s           0 B/op          0 allocs/op
BenchmarkRC4_1K-12        704779              1532 ns/op         668.28 MB/s           0 B/op          0 allocs/op
BenchmarkRC4_8K-12         96313             12660 ns/op         639.48 MB/s           0 B/op          0 allocs/op

cipher.go Outdated Show resolved Hide resolved
Co-authored-by: Davis Goodin <[email protected]>
@qmuntal
Copy link
Collaborator Author

qmuntal commented Oct 11, 2023

@derekparker @ueno I'll be taking a long leave soon and I'll like to have this PR as ready as possible to be merged. Could you take a look? Thanks!

Copy link
Collaborator

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qmuntal qmuntal merged commit 78dacc3 into v2 Oct 12, 2023
16 checks passed
@qmuntal qmuntal deleted the rc4 branch October 12, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants