Context cancellation #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stapelberg
approved these changes
Mar 2, 2022
|
I think I missed one change when I submitted this, sorry, from rsynctest.go edit: yup, will fix it |
currently when context is canceled, and if in Serve() based Accept() loop, the process is shut down without waiting for the client connections to gracefully exit. not sure if graceful handling would be worth the effort.
joonas-fi
force-pushed
the
feat-context-cancellation
branch
from
eb7b06e to
a17e0b5
Compare
|
Thanks! |
joonas-fi
added a commit
to joonas-fi/rsync
that referenced
this pull request
Mar 3, 2022
currently when context is canceled, and if in Serve() based Accept() loop, the process is shut down without waiting for the client connections to gracefully exit. not sure if graceful handling would be worth the effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus work found during #12
(Extracted from previous PR: #11)