Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep frame shadow for fullscreen windows #66

Open
lewtds opened this issue Jul 11, 2013 · 5 comments
Open

Keep frame shadow for fullscreen windows #66

lewtds opened this issue Jul 11, 2013 · 5 comments
Milestone

Comments

@lewtds
Copy link
Contributor

lewtds commented Jul 11, 2013

Since we decided to implement #49 (so that Plank never hides), fullscreen windows now aren't really fullscreen, there still Plank underneath it. According to Elementary's metacity theme (the window decoration theme), fullscreen windows shall have no drop shadow. That can get a little weird after the users have already become accustomed to the drop shadow.

I understand that the above explanation might be confusing. So here's a normal window with shadow:
hnh chp t 2013-07-12 02 24 19

Here's the same window fullscreen-ed and without shadow:
hnh chp t 2013-07-12 02 24 24

@fuzzysource
Copy link

Do you think that the shadow would conflict with the background of the dock?

@lewtds
Copy link
Contributor Author

lewtds commented Jul 13, 2013

That wouldn't happen if the Dock is set to be always on top. Try opening two windows and make one of them always on top, the shadow of the other window cannot cover the top window.

@fuzzysource
Copy link

I mean the shadow could be broken by the dock. Is it ugly or not.

On Sat, Jul 13, 2013 at 9:28 PM, Trung Ngo [email protected] wrote:

That wouldn't happen if the Dock is set to be always on top. Try opening
two windows and make one of them always on top, the shadow of the other
window cannot cover the top window.


Reply to this email directly or view it on GitHubhttps://github.com//issues/66#issuecomment-20920620
.

Đàm Tiến Long
Email: [email protected]
Twitter: https://twitter.com/#!/fuzzysource
Homepage: http://fuzzysource.github.com

@lewtds
Copy link
Contributor Author

lewtds commented Jul 13, 2013

Let's just do it and see. Personally I don't think that's a big issue.

@ghost ghost assigned hainp2604 Jul 15, 2013
@MikeLP
Copy link

MikeLP commented Aug 15, 2015

It's 100% is a bug (in Elementary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants