Fix runeSliceWidthRange implementation
#1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Looks great, but I've only glanced at it so far. I'd like to try this out and think about potential bugs some more, perhaps learn something about runes and Unicode. If somebody else can review it faster than me, feel free! |
|
@joelim-work Looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1270
I have decided to submit the proposed changes to the
runeSliceWidthRangefunction, and added some more unit tests to cover scenarios which aren't handled by the current implementation. In my opinion, it is important to ensure the internal API is robust, otherwise it can become difficult to add new changes.Thanks to @raslop for having a look at this beforehand.