Expand tilde during autocompletion #1246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1175
When typing commands like
:echo ~/foo.txt
, the autocompletion will internally expand the tilde for matching purposes, but when the command is evaluated afterwards, the tilde is not expanded. This is very confusing for users, and raises the question of why the autocompletion respects the tilde when matching in the first place.I can see two possible solutions:
This PR uses the first approach. While I think the second approach is easier to implement, the problem is that unconditionally tilde expanding every argument after the parsing stage means that there is no way for the user to pass a literal tilde by quoting or escaping it.