Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct multierror is not support Unwrap method #5

Open
viartos opened this issue May 27, 2020 · 0 comments
Open

Struct multierror is not support Unwrap method #5

viartos opened this issue May 27, 2020 · 0 comments

Comments

@viartos
Copy link

viartos commented May 27, 2020

For correct working go 1.13 error chains (including errors.Is()) needs implementation of interface:

type wrapper interface {
	Unwrap() error
}

For example:
when i use github.com/gojek/heimdall and if at the time of request occurred context cancel, i am check it as if errors.Is(err, context.Canceled) {}, but it's not work because heimdall use valkyrie multierror that does't support method Unwrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant