-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove feature set status check for job update requirement #708
Conversation
/test test-end-to-end-batch-dataflow |
/test test-end-to-end |
/test test-end-to-end-batch-dataflow |
a89c6dc
to
a3b38a9
Compare
/test test-end-to-end-batch-dataflow |
96534ef
to
528a16c
Compare
/test test-end-to-end-batch-dataflow |
528a16c
to
ae35fe9
Compare
/test test-end-to-end-batch-dataflow |
/test test-end-to-end-batch-dataflow |
@khorshuheng: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Currently, a job is deemed to require update if one or more associated feature set is in pending state. This leads to infinite loop in which the job manager keep updating existing task but the job status never becomes successful:
Feature set equality check should have sufficed to determine if a job requires update.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: