make multiselectfield init more robust #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a newer version of chafield, the max length is no longer required and the validator may be missing. This code should fix that. Minor note I want to add: the init code of Field actually caused the maxlen validator to be last, not first, so you'd need to always take [-1] instead of [0] or you'd overwrite user-supplied validators (but that's also fixed here)
|
Also see #132, fixes the same problem in a different way |
|
Fixed in #148. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a newer version of chafield, the max length is no longer required and the validator may be missing. This code should fix that. Minor note I want to add: the init code of Field actually caused the maxlen validator to be last, not first, so you'd need to always take [-1] instead of [0] or you'd overwrite user-supplied validators (but that's also fixed here)