Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hyphens in locale name #2

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Allow hyphens in locale name #2

merged 1 commit into from
Feb 14, 2022

Conversation

jmooring
Copy link
Member

@bep
Copy link
Member

bep commented Feb 12, 2022

OK, let's start over, I was a little fast earlier. Why does this change require change in 4 files? I suspect some of them are formatting changes, but with thousands of lines changed, it's not possible for me to decide.

locales_test.go Outdated Show resolved Hide resolved
@jmooring
Copy link
Member Author

Why does this change require change in 4 files?

currencies.autogen.go  --> auto-generated by gen/main.go
locales.autogen.go     --> auto-generated by gen/main.go
locales.go
locales_test.go

@bep
Copy link
Member

bep commented Feb 12, 2022

If you can narrow down this change set to the 1 file (+ test) that is touched by this change, I will merge it.

And yes, I understand your point, but dont't have the time to figure out why your go generate generates different from mine, and I certainly cannot spend time on the 10K line diff.

@bep
Copy link
Member

bep commented Feb 13, 2022

OK, I guess the go generate script does not apply gofmt, which would explain the diff, but I still don't see why you would need to regenerate these files for this particular patch.

@jmooring
Copy link
Member Author

I still don't see why you would need to regenerate these files

I apologize. I didn't see any harm in doing so. I have reverted those changes.

@bep
Copy link
Member

bep commented Feb 14, 2022

I apologize. I didn't see any harm in doing so. I have reverted those changes.

The bigger the diff, the harder is to merge.

@bep bep merged commit 4e2b67f into gohugoio:main Feb 14, 2022
@jmooring jmooring deleted the fix/language-locale-mismatch-2 branch February 14, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization fails if language does not match locale
2 participants