commands: Fix server panic regression #9540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And now with a proper server test. Fixes gohugoio#9518 Fixes gohugoio#9530 Fixes gohugoio#9539
bep
force-pushed
the
fix/panic-regression-9518
branch
from
8523c3c to
dae1849
Compare
|
I have admittingly only tested one of the cases above (which is now also added as an integration test), but I assume the cause is the same. |
I just build |
Just did, and I don't see how you could get the stack trace your reported after my patch, which must suggest that you 1. Either did not build this version or 2. Got a different error. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And now with a proper server test.
Fixes #9518
Fixes #9530
Fixes #9539