Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix erroneous warning with .Page.RenderString on a page without a backing file #9438

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Fix erroneous warning with .Page.RenderString on a page without a backing file #9438

merged 1 commit into from
Jan 28, 2022

Conversation

bep
Copy link
Member

@bep bep commented Jan 28, 2022

Fixes #9433

@bep bep force-pushed the fix/render-warning-9433 branch from fa4fad1 to ec52472 Compare January 28, 2022 08:56
@bep bep requested a review from jmooring January 28, 2022 08:59
jmooring
jmooring approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@jmooring jmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Thank you for taking care of this.

@bep bep merged commit ef7d14a into gohugoio:master Jan 28, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmooring jmooring jmooring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invoking .Page.RenderString on a page without a backing file throws an erroneous warning
2 participants
@bep @jmooring