Add clock cli flag

[satotake]

issue #8787
If I understand @regisphilibert 's comment properly, with the flag, users want to check

• future/expired content's manners
• now in template
• hugo list output

If so, we can implement this flag by just replacing a few of time.Now() without changing internal time of go.

This PRs add buildTime flag in order to fake hugo's build datetime like so

hugo --buildTime 2021-11-06
hugo --buildTime 2021-11-06 server
hugo --buildTime 2021-11-06 list future
hugo --buildTime 2021-11-06 list expired

Close #8787

[flimzy]

This is a feature that would make my life a lot easier. What are the chances of getting this reviewed and rebased any time soon?

[davidsneighbour]

This is a feature that would make my life a lot easier. What are the chances of getting this reviewed and rebased any time soon?

Thumbs up and useful contributions tend to do that ;)

The "build time" moniker is slightly misleading but I like the concept. If it has enough testing to make sure it works as expected and when the "conflicts that must be resolved" are resolved (probably just a fetch of the current HEAD and re-check) our little conversation here will put it in the TODO pile again and someone who knows Golang will surely have a look.

[flimzy]

@satotake Are you still interested in this issue/PR? If not, I'd be happy to take it over and do a rebase in a new PR.

[satotake]

Honestly, this PR has been a dim memory for me but rebasing and resolving were not so tough.
Thanks for your offer, @flimzy .

If you do not mind, could you review this PR or have any idea, @bep?
Especially, my concern is flag name as @davidsneighbour said.
Of course, it is ok for me to change the name.

[bep]

OK, I have thought some more about this, and I think we need to do an adjustment.

The thing is, when we're changing the build time, I also suspect people would also expect the clock to change in other situations, e.g.:

{{ ge .PublishDate now }}

Should always print true.

With that in mind, I think we need a ... clock.

What I suggest is that we

• rename the buildTime flag to clock (?)
• rework the implementation in this PR to also consider the system clock. I have toyed around with this package tonight, which I thinks should be simple enough to reason about: https://github.com/bep/clock
• Replace all usage of time.Now with htime.Now

Thoughts?

[satotake]

rename the buildTime flag to clock (?)

Looks good. I thought just time or date might be ambiguous for this.

rework the implementation in this PR to also consider the system clock. I have toyed around with this package tonight, which I thinks should be simple enough to reason about: https://github.com/bep/clock

I have presumed fixed time for this. yes but it is ok to make it running. I will check it your package.

Replace all usage of time.Now with htime.Now

Not sure but I suspect that they are not all but most. For example, values for logging and so on? Anyway, I will check it, too.

[bep]

Thanks, I have rebased this into a new PR and will finish this in #9864

[satotake]

ok

I replaced time.Now with htime.Now as much as possible (including logging) for now.

except for

• values in tests
• seed value for random
• cloudfront deploy

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.