Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources: Rename excepted filenames for image golden testdata #9093

Merged

Conversation

anthonyfok
Copy link
Member

@anthonyfok anthonyfok commented Oct 29, 2021

As documented in commit 30eea39,
some filenames have changed due to cache busting of PNG and Webp images.

This resolves recent TestImageOperationsGolden failure on arm64, ppc64le
and s390x.

See #6387 and #8729


Error message (excerpted from https://buildd.debian.org/status/fetch.php?pkg=hugo&arch=arm64&ver=0.86.1-1&stamp=1635264173&raw=0):

=== CONT  TestImageOperationsGolden
    ...
    image_test.go:744: resulting image differs from golden: gohugoio8_hu7f72c00afdf7634587afaa5eff2a25b2_73538_73c19c5f80881858a85aa23cd0ca400d.png
    image_test.go:744: resulting image differs from golden: gohugoio8_hu7f72c00afdf7634587afaa5eff2a25b2_73538_ae631e5252bb5d7b92bc766ad1a89069.png
    image_test.go:744: resulting image differs from golden: gohugoio8_hu7f72c00afdf7634587afaa5eff2a25b2_73538_d1bbfa2629bffb90118cacce3fcfb924.png
--- FAIL: TestImageOperationsGolden (15.40s)

As documented in commit 30eea39,
some filenames have changed due to cache busting of PNG and Webp images.

This resolves recent TestImageOperationsGolden failure on arm64, ppc64le
and s390x.

See gohugoio#6387 and gohugoio#8729
@bep bep merged commit dce49d1 into gohugoio:master Oct 30, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants