Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent minifier from removing quoutes around post-processed attributes #8908

Merged
merged 1 commit into from
Aug 22, 2021
Merged

Prevent minifier from removing quoutes around post-processed attributes #8908

merged 1 commit into from
Aug 22, 2021
+12 −1

Conversation

bep
Copy link
Member

@bep bep commented Aug 19, 2021

Fixes #8884

@bep bep requested a review from jmooring August 19, 2021 09:32
jmooring
jmooring approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@jmooring jmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with MRE from #8884. Also verified that TestResourceChainPostProcess fails when = removed from PostProcessSuffix.

Thanks for the fix.

@bep bep merged commit bc0743e into gohugoio:master Aug 22, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmooring jmooring jmooring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fingerprinting + PostProcess + HTML minify causes HTML validation errors
2 participants
@bep @jmooring